Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18N: Date picker does not respect language settings #11734

Closed
spacedmonkey opened this issue Jun 17, 2022 · 4 comments · Fixed by #11745
Closed

I18N: Date picker does not respect language settings #11734

spacedmonkey opened this issue Jun 17, 2022 · 4 comments · Fixed by #11745
Labels
Group: Document Panel Internationalization (I18N) Package: Story Editor /packages/story-editor Type: Bug Something isn't working

Comments

@spacedmonkey
Copy link
Contributor

Bug Description

When setting WordPress to another language, the date picker does not respect the langauge WordPress is set on.

Expected Behaviour

Steps to Reproduce

  1. Go to settings > general.
  2. Set language to Spanish.
  3. Go to story editor.
  4. Go to document panel.
  5. Change date of story.
  6. Set translated date picker.

Screenshots

Screenshot 2022-06-17 at 12 54 36

Additional Context

  • Plugin Version:
  • WordPress Version:
  • Operating System:
  • Browser:
@spacedmonkey
Copy link
Contributor Author

Created a simple workaround for this issue. See #11733

@swissspidy swissspidy changed the title I18N: Date picker does not respect langauge settings I18N: Date picker does not respect language settings Jun 20, 2022
@swissspidy
Copy link
Collaborator

#11745 is an alternative approach, as previously discussed. PTAL

Also opened wojtekmaj/react-calendar#620 since not everything can be localizad that way yet.

@spacedmonkey
Copy link
Contributor Author

spacedmonkey commented Jun 20, 2022 •
edited by swissspidy
Loading

#11745 is an alternative approach, as previously discussed. PTAL

What this work for custom languages in WP?

@swissspidy
Copy link
Collaborator

Yes. The screenshot on that PR is an example from when I used the Romansh locale in WordPress. Works out of the box.

@swissspidy swissspidy mentioned this issue Jun 24, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: Document Panel Internationalization (I18N) Package: Story Editor /packages/story-editor Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calendar: Pass custom formatters to react-calendar GoogleForCreators/web-stories-wp
2 participants
@spacedmonkey @swissspidy