Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eyedropper using SVG rendered page #262

Closed
jauyong opened this issue Feb 7, 2020 · 4 comments · Fixed by #7961
Closed

Implement eyedropper using SVG rendered page #262

jauyong opened this issue Feb 7, 2020 · 4 comments · Fixed by #7961
Assignees
Labels
Group: Patterns Includes features like color picker and overlays Group: Style Panel Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P1 High priority, must do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@jauyong
Copy link

jauyong commented Feb 7, 2020

Feature Description

Implement the eyedropper as per design in figma.

  • When the user clicks the eyedropper in the color picker, close/minimize the color picker, so the full canvas is visible and enable "eyedropper-mode"
  • Replace the current page canvas with a static SVG-rendered version of the page canvas rendered to an HTML canvas
    • Note that this looks like the previously selected element(s) has been deselected (no selection frame visible), but this is only while eye-dropping. The same element(s) remains selected and the design panel remains the same.
  • When the user is in "eyedropper-mode", the cursor changes to a custom cursor
    • When over the page canvas the custom cursor is some sort of zoom of the pixel color directly below the cursor 🔍
    • When over anything but the page canvas, the cursor is some sort of "not available" cursor 🛑
    • Review cursors with UX team
  • Regardless of where the user clicks, exit "eyedropper-mode", revert the page to the regular display page, restore selection (only visually, selection never actually changed)
    • If the user was over the page canvas when clicking, use the pixel color under the cursor at the time of click to set as the active color for whatever the color picker was opened for originally

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

@jauyong jauyong added P0 Critical, drop everything Version 1.0 labels Feb 7, 2020
@swissspidy swissspidy mentioned this issue Feb 10, 2020
5 tasks
@jauyong jauyong added this to the Sprint 23 milestone Feb 10, 2020
@jauyong jauyong removed P0 Critical, drop everything Version 1.0 labels Feb 13, 2020
@kmyram kmyram added the P1 High priority, must do soon label Mar 6, 2020
@swissspidy swissspidy removed this from the Sprint 23 milestone Mar 24, 2020
@jauyong jauyong added P2 Should do soon and removed P1 High priority, must do soon labels Apr 9, 2020
@wassgha wassgha self-assigned this Jul 4, 2020
@swissspidy
Copy link
Collaborator

Proof-of-concept: #3007

@swissspidy swissspidy reopened this Sep 22, 2020
@barklund barklund added the Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar label Oct 5, 2020
@barklund
Copy link
Contributor

@swissspidy review?

@swissspidy
Copy link
Collaborator

@barklund whoops, looks like I edited the wrong issue. #4081 / #5027 can be reviewed, not this one.

@swissspidy swissspidy added Group: Style Panel Group: Patterns Includes features like color picker and overlays Type: Enhancement New feature or improvement of an existing feature labels Oct 28, 2020
@swissspidy swissspidy changed the title Color Picker - Eye Dropper Color Picker - Eyedropper Oct 28, 2020
@barklund barklund changed the title Color Picker - Eyedropper Implement eyedropper using SVG rendered page May 21, 2021
@barklund barklund added P1 High priority, must do soon UX Needed and removed P2 Should do soon labels May 21, 2021
@merapi merapi mentioned this issue Jun 16, 2021
18 tasks
@miina miina removed the UX Needed label Jul 6, 2021
@csossi
Copy link

csossi commented Jul 7, 2021

Finding the eyedropper a little cumbersome to use. As I move it around a solid colour, I see flickers of #FFF appearing (if user inadvertently selects, colour selected will be white) and it requires user to be precise in selection. See video

https://share.getcloudapp.com/X6uAXXDG

When the full 6-digit code appears and user selects, everything's working fine - it just ain't pretty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Patterns Includes features like color picker and overlays Group: Style Panel Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P1 High priority, must do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
8 participants