You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#3389 removes an accidentally-merged debug print that @Bckempa noticed made it all the way to the 3.0.1 release.
As @ryneeverett suggests, this wasn't caught in tests because they all check that the output contains some particular string -- if there's extra stuff that doesn't cause the test to fail. In general, that's good, but we should probably also have some tests that assert that exactly the expected output is present, for some simple kinds of output.
Maybe a good one of those would be task ls for an empty task database, along with the necessary rc.foo=.. to silence things that might change like task news output.
The text was updated successfully, but these errors were encountered:
This is only half true, some tests especially the python tests would have caught that e.g.
70: # FAIL: AssertionError on file /usr/lib64/python3.12/unittest/case.py line 58 in testPartExecutor: 'yield':
70: # '1' unexpectedly found in '3.0.1'
however as noted in #3388 the tests were not run...
#3389 removes an accidentally-merged debug print that @Bckempa noticed made it all the way to the 3.0.1 release.
As @ryneeverett suggests, this wasn't caught in tests because they all check that the output contains some particular string -- if there's extra stuff that doesn't cause the test to fail. In general, that's good, but we should probably also have some tests that assert that exactly the expected output is present, for some simple kinds of output.
Maybe a good one of those would be
task ls
for an empty task database, along with the necessaryrc.foo=..
to silence things that might change liketask news
output.The text was updated successfully, but these errors were encountered: