-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PropertiesFileTransformer break reproducible builds #584
Comments
@chrko Did you find a way around this? |
facing this issue. any workaround? |
This happens because PropertiesFileTransformer is using Properties.store method which will add the timestamp anyways. Would be nice to change this so that the unnecessary time comment is removed instead. |
I believe the intent of #622 was to address this issue. |
Introduced CleanProperties in 8 or 8.1. |
Shadow Version
6.0.0
Gradle Version
6.5.1
Expected Behavior
Reproducible build = hash of resulting file within
build/lib
Actual Behavior
The
PropertiesFileTransformer
writes the current time into the generated files which breaks the reproducible build.Gradle Build Script(s)
I'm currently trying to build a fat application jar with spring dependencies and applying the following: spring-projects/spring-boot#1828 (comment)
I will try to reduce my current
build.gradle
to ease reproduction and will append this.Content of Shadow JAR (
jar tf <jar file>
- post link to GIST if too long)…
META-INF/services/org.apache.logging.log4j.util.PropertySource
META-INF/spring.handlers
META-INF/spring.schemas
META-INF/spring.tooling
META-INF/spring.factories
Content of spring.factories:
The text was updated successfully, but these errors were encountered: