Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow 8.1.0 has not been published to gradlePluginPortal #827

Closed
Goooler opened this issue Feb 27, 2023 · 6 comments
Closed

Shadow 8.1.0 has not been published to gradlePluginPortal #827

Goooler opened this issue Feb 27, 2023 · 6 comments

Comments

@Goooler
Copy link
Member

Goooler commented Feb 27, 2023

Check https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow/8.1.0

@Goooler
Copy link
Member Author

Goooler commented Feb 27, 2023

CC @johnrengelman

@johnrengelman
Copy link
Collaborator

Yeah with all the changes in the plugin publishing it went into a manual review state. Not sure exactly why. Will find out when one of their engineers looks tomorrow hopefully.

@johnrengelman
Copy link
Collaborator

It appears this is because the maven targets changed from gradle.plugin.com.github.johnrengelman:shadow:8.0.0 to com.github.johnrengelman:shadow:8.1.0.
Note the dropped gradle.plugin. prefix.

This wasn't being manually configured before, so I suspect it's due to the version update of com.gradle.plugin-publish. If that's the case (which I queried Gradle about), I think I'll just publish this as is with a note about the coordinate change (dropping the gradle.plugin. was mentioned by the Gradle engineer as the desired path forward).

@Goooler
Copy link
Member Author

Goooler commented Feb 27, 2023

Yeah, that might be the reason.

@Goooler
Copy link
Member Author

Goooler commented Feb 28, 2023

Alright, it is finally out.

@Goooler Goooler closed this as completed Feb 28, 2023
@Goooler
Copy link
Member Author

Goooler commented Feb 28, 2023

I think I'll just publish this as is with a note about the coordinate change

And a few things are worthy to note, see #835 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants