Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test data for categorySpec doesn't always reflect expected return data #157

Open
1 task done
Jonathan-Zollinger opened this issue Aug 23, 2024 · 0 comments
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@Jonathan-Zollinger
Copy link
Member

Jonathan-Zollinger commented Aug 23, 2024

Current Behavior

the logs aren't super helpful, but some category endpoints return data which doesn't include pricing. that may be because it doesn't include products or a parent object to pricing

We want to be sure this isn't a one-off problem.

this isn't one off, but it doesn't happen consistently since i dont know which data set produces this

Expected Behavior

tests dont expect non-null pricing when the endpoint doesn't provide a price.

Steps To Reproduce

run default maven tests. once in a while one fails

A picture is worth a thousand words

failed test output:

[ERROR] Failures:
[ERROR]   ThreshrControllerSpec.query product summary for category #id returns expected data:64 Condition not satisfied:

search.products().collect { null != it.price() }
|      |          |
|      []         []
Search[searchRecommendations=SearchRecommendations[categoryId=5xsxf, relatedCategories=null], searchResponse=SearchResponse[metadata=Metadata[responseIds=[Ljava.lang.String;@5257f99d, count=24, currentPage=1, keyword=null, offset=0, sortBy=bestselling, totalPages=0, totalResults=0, sortOptions=null], facets=null, visualFacets=null], searchSuggestions=null, products=[Lcom.graqr.threshr.model.redsky.product.Product;@7f2d4421]

Environment

NA

Code of Conduct

@Jonathan-Zollinger Jonathan-Zollinger added the bug Something isn't working label Aug 23, 2024
@Jonathan-Zollinger Jonathan-Zollinger self-assigned this Aug 23, 2024
@Jonathan-Zollinger Jonathan-Zollinger changed the title Test data for pagespec doesn't always reflect expected return data Test data for categorySpec doesn't always reflect expected return data Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant