Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GravityRevision's Fields to Field Settings #132

Open
bennemann opened this issue Jun 27, 2022 · 3 comments
Open

Add GravityRevision's Fields to Field Settings #132

bennemann opened this issue Jun 27, 2022 · 3 comments

Comments

@bennemann
Copy link

From a customer:

_Neither Revision Parent Date; Revision Created By; Revision Changed Content; nor Revision Date (GMT) is displayed in the export. However, it is perfectly displayed in the individual entries. _

There are the available keys:
gv_revision_user_id
gv_revision_changed
gv_revision_date_gmt
gv_revision_parent_id
gv_revision_date

@bennemann
Copy link
Author

@doekenorg
Copy link
Collaborator

@bennemann I would like some extra input on this.

Technically there is nothing to export. These fields are registered as meta fields, but are not actually filled out on the entry. There is another entry created for every revision. And only on those entries are these fields filled out.

Obviously we can retrieve these values, and add them to the fields for the current entry. There are a few points that need clearing up though.

  • gv_revision_parent_id will always be the same as the entry id. Because that is the link it uses to retrieve the related revisions. Not sure if this is useful.
  • gv_revision_changed is only a JSON-blob of the difference of the change <- we can format this, but how?

It just doesn't feel very useful to have in the export.

It could be nice to have additional rows for every revision, where only the difference is shown for example, or where those fields are highlighted in some way. That would make way more sense to me. However, it will probably be in reverse, because the current entry is already the most up to date.

Perhaps @zackkatz / @rafaehlers could also weigh in on this.

In the last case, I think we should actually remove those revision meta fields from the export (this would be better to do on the original plugin though), and add one or more options on the exports to show the revisions, and how.

And maybe only show this on the single entry export? It would mess up the regular export big time :-) Here are two examples I can think off. Both are annoying to build though 😆

Schermafbeelding 2022-07-16 om 21 44 42

Schermafbeelding 2022-07-16 om 21 52 59

@rafaehlers
Copy link
Contributor

Perhaps we should wait for more interested customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants