Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all settings to Foundation if Foundation exists #154

Open
zackkatz opened this issue Jan 19, 2023 · 6 comments
Open

Add all settings to Foundation if Foundation exists #154

zackkatz opened this issue Jan 19, 2023 · 6 comments

Comments

@zackkatz
Copy link
Member

zackkatz commented Jan 19, 2023

If Foundation exists, the settings should be in a GravityExport tab (not a separate GravityExport Lite tab).

We need to think about where the setting would be saved (in the prior setting key or in Foundation settings…)

@doekenorg
Copy link
Collaborator

@zackkatz You say

If Foundation exists

But that's on us, right? Wouldn't Foundation be included in the next major? Or is that not shipped with the plugin?

If it is, I think we should port the settings to Foundation for consistency. If it isn't; then we should keep it on the plugin, to avoid having multiple places.

@zackkatz
Copy link
Member Author

zackkatz commented Jan 30, 2023

We haven't prepared Foundation for .org. It will take some amount of work to make it compliant. @doekenorg

@doekenorg
Copy link
Collaborator

Right, so In that case; I guess we could check for Foundation; and duplicate the settings over there; whilst saving them to the plugin for BC.

@mrcasual
Copy link
Collaborator

Another option is to integrate Foundation but disable products/licensing if it's just GravityExport Lite that's using it.

@doekenorg
Copy link
Collaborator

Another option is to integrate Foundation but disable products/licensing if it's just GravityExport Lite that's using it.

I like this option best TBH. Since we are moving to 2.0, this is the best time to introduce a new settings page + location where the settings are stored.

@zackkatz
Copy link
Member Author

@mrcasual we would need opt-in metrics reporting and Beacon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants