Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory impact of loading entire dictionaries into memory #80

Open
GrayedFox opened this issue Oct 6, 2020 · 0 comments
Open
Labels
chore Refactoring, maintenance, fine tuning, all that jazz fuzzy For when it's not clear what the problem is or the fix should be help wanted Medic!

Comments

@GrayedFox
Copy link
Owner

GrayedFox commented Oct 6, 2020

Right now dictionaries are not buffered, but are rather read in their entirety before being used to instantiate a User:

Offending helper method that reads dictionaries.

Here the result is used to instantiate a User.

This is a massive resource hit and could likely be done better but I'm not quite sure how. Hopefully we don't need to wait until the web-extensions API exposes the actual browser spell checker (which would remove the need for nspell entirely) but that may be the case.

@GrayedFox GrayedFox added chore Refactoring, maintenance, fine tuning, all that jazz help wanted Medic! fuzzy For when it's not clear what the problem is or the fix should be labels Oct 6, 2020
@GrayedFox GrayedFox added help wanted Medic! and removed help wanted Medic! labels Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactoring, maintenance, fine tuning, all that jazz fuzzy For when it's not clear what the problem is or the fix should be help wanted Medic!
Projects
None yet
Development

No branches or pull requests

1 participant