Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WHOIS adapter handling of multiple results #179

Open
5 of 9 tasks
waab76 opened this issue Nov 19, 2020 · 0 comments · Fixed by #180, #181 or #182
Open
5 of 9 tasks

Improve WHOIS adapter handling of multiple results #179

waab76 opened this issue Nov 19, 2020 · 0 comments · Fixed by #180, #181 or #182
Assignees
Labels
bug #M > 1d <= 3d

Comments

@waab76
Copy link
Contributor

waab76 commented Nov 19, 2020

Currently, when ARIN has multiple results for an IP address, the WHOIS data adapter fails to return data. Sample IPs that demonstrate this include 24.255.164.88, 65.118.97.162, and 68.110.253.17

In each of these cases, ARIN has multiple records with different Network Type values. We want to update the WHOIS plugin to better handle these cases and return the data from the most specific record. The preference order for Network Types will be:

  1. Reassigned
  2. Direct Assignment
  3. Direct Allocation
  4. Reallocated

Input Criteria

  • WHOIS data adapter works

Output Criteria

  • When a single record is present, data adapter returns data for that record
  • When multiple records are present, data adapter returns data for the record with the most preferred Network Type
  • Fix backported to 4.0
  • Fix backported to 3.3

Tasks

  • Update ARIN parser to handle multiple records
  • Write JUnit tests for behavior
  • Backport to 4.0
  • Backport to 3.3
@waab76 waab76 added bug #M > 1d <= 3d labels Nov 19, 2020
@waab76 waab76 added this to the 4.1.0 milestone Nov 19, 2020
@waab76 waab76 self-assigned this Nov 19, 2020
@waab76 waab76 linked a pull request Nov 23, 2020 that will close this issue
@waab76 waab76 reopened this Nov 23, 2020
@waab76 waab76 linked a pull request Nov 23, 2020 that will close this issue
@bernd bernd removed this from the 4.1.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment