Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage #58

Merged
merged 23 commits into from
Mar 21, 2024
Merged

Add test coverage #58

merged 23 commits into from
Mar 21, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • add test coverage for all plugins and validations.ts file
  • fix validations and minor bugs

@manushak
test(lib): cover cloud-metedata test
79bfda8
@manushak
fix(lib): remove unnecessary check in cloud-metadata
53ce07b
@manushak
test(lib): cover csv-export plugin tests
1040aca
@manushak
test(lib): cover divide plugin test
c07a8c7
@manushak
test(lib): add coverage for regex plugin
8cf6ab8
@manushak
fix(lib): fix regex validation check
1bbfa03
@manushak
test(lib): add coverage for sci plugin
91317cc
@manushak
test(lib): add test coverage for sci-m plugin
5531acf
@manushak
fix(lib): remove unnecessary function in sci-m
be6b515
@manushak
test(lib): add coverage for tdp-finder plugin
631e199
@manushak
test(lib): add test coverage for shell plugin
fed861f
@manushak
test(lib): add test coverage for commom-generator of mock-observation…
29732b7 
…s plugin
@manushak
test(lib): add assertion in common-generartor test
1958a52
@manushak
test(lib): add test coverage for RandIntGenerator of mock-observation…
566909a 
…s plugin
@manushak
fix(lib): add validation for global config in mock-obervations
3bb7983
@manushak
test(lib): add test coverage for mock-observations plugin
2385594
@manushak
test(lib): add tests for validations.ts
573f25b
@manushak
Merge branch 'main' into test-coverage
ae2712c
jmcook1186
jmcook1186 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmcook1186 jmcook1186 merged commit 5050060 into main Mar 21, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the test-coverage branch March 21, 2024 14:42
@manushak manushak mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manushak @narekhovhannisyan @jmcook1186 @MariamKhalatova