Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Watt-time plugin #65

Merged
merged 30 commits into from
Apr 9, 2024
Merged

Improve Watt-time plugin #65

merged 30 commits into from
Apr 9, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • improve watt time plugin
  • change dayjs to luxon
  • add logic to avoid requesting if the duration is less than 5 minutes, and set the previous emission value to the current one

@manushak manushak added awaiting-dev-review PR is awaiting review from core dev fix PR fixes a bug or improves something size: medium medium sized task labels Mar 27, 2024
@manushak manushak linked an issue Mar 27, 2024 that may be closed by this pull request
Regain 100% unit test coverage post-refactor Green-Software-Foundation/if#496
Closed
jmcook1186
jmcook1186 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmcook1186 jmcook1186 added dev-review-pass PR has been approved by core dev awaiting-qa PR is waiting for QA approval and removed awaiting-dev-review PR is awaiting review from core dev labels Mar 28, 2024
@jmcook1186 jmcook1186 mentioned this pull request Apr 2, 2024
Closed
@manushak manushak linked an issue Apr 2, 2024 that may be closed by this pull request
Geolocation in Watt-time doesn't work properly Green-Software-Foundation/if#570
Closed
@manushak manushak requested a review from jmcook1186 April 3, 2024 12:24
@manushak
fix(lib): add check for geolocation/ 'cloud/region-wt-id'
930ddd9 
-check if the geolocation or cloud/region-wt-id is the same when the duration is lower then 5 mins
@manushak manushak linked an issue Apr 8, 2024 that may be closed by this pull request
[Watt-time] Signal type is ignored when geolocation is in inputs Green-Software-Foundation/if#583
Closed
This was linked to issues Apr 9, 2024
Add validation step that checks time resolution is >300s for pipelines that use Watt-time Green-Software-Foundation/if#533
Closed
[Watt-time] Unhandled error when env variables are invalid Green-Software-Foundation/if#584
Closed
@manushak manushak self-assigned this Apr 9, 2024
@MariamKhalatova MariamKhalatova merged commit 907309f into main Apr 9, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the watt-time-plugin branch April 9, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees

@manushak manushak

Labels
awaiting-qa PR is waiting for QA approval dev-review-pass PR has been approved by core dev fix PR fixes a bug or improves something size: medium medium sized task
Projects
None yet
Milestone
No milestone
4 participants
@manushak @narekhovhannisyan @jmcook1186 @MariamKhalatova