Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Watttime credentials to .env file #470

Closed
jmcook1186 opened this issue Feb 27, 2024 · 1 comment · Fixed by Green-Software-Foundation/if-unofficial-plugins#41
Closed
Assignees

Comments

@jmcook1186
Copy link
Contributor

Story

As a user I want to use Watttime but don't want to expose my username and password in the manifest file.

Rationale

We should have the username and password in environment variable, similar to the Azure credentials in the azure importer plugin.

Implementation details

Remove username and password from config and instead load them from .env file.

Priority

2/5

Scope

Affects the watttime plugin

Size

0.5 d

What does "done" look like?

Watttime plugin gets credentials from environment variables

Does this require updates to documentation or other materials??

yes, update plugin readme

What testing is required?

unit tests must pass

Is this a known/expected update?

not previously discussed

@jmcook1186 jmcook1186 added this to the IF Sprint 7: 19/03/24 - 01/03/24 milestone Feb 27, 2024
@jmcook1186 jmcook1186 added this to IF Feb 27, 2024
@manushak manushak self-assigned this Feb 29, 2024
@manushak manushak moved this to Pending Review in IF Feb 29, 2024
@jmcook1186
Copy link
Contributor Author

Closing as complete

@github-project-automation github-project-automation bot moved this from Pending Review to Done in IF Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants