-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dev ticket template #642
Conversation
.github/ISSUE_TEMPLATE/dev-ticket.md
Outdated
<!--- enumerate specific changes required to the documentation, formatted as checkboxes with associated urls --> | ||
|
||
## Testing | ||
<!--- what tests are required for the changes to get merged? Please use checkboxes!--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to leave at least one line of checkboxes so you don't have to figure out how to write it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point - adding now
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Thanks @jmcook1186, every project is now being asked to align to the pm protocol here: https://www.notion.so/grnsft/Internal-Project-Protocol-6b8a9e881ed942df9a81a60aeecfd998?pvs=4 head to the section called "issues". So this will need to change somewhat to conform. Specifically for IF the ticket should look something like so which follows the protocol and merges with your suggestions. What: one sentence to describe the deliverable. In addition
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my comment on the PR
rm reviewer field Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
|
||
## Acceptance criteria | ||
<!--- What has to be true for this to get merged? What threshold of testing is acceptable? --> | ||
**Acceptance criteria** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmcook1186 let's add to the template to trigger thinking in that style
Given ...
When ...
Then ...
Signed-off-by: jmc <33655003+jmcook1186@users.noreply.github.com>
Signed-off-by: Asim Hussain <asim@codecraft.tv>
A description of the changes proposed in the Pull Request
Updates developer ticket template according to discussion here: #613