Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump logs errors #691

Merged
merged 21 commits into from
May 12, 2024
Merged

Dump logs errors #691

merged 21 commits into from
May 12, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Implemented error logging into output file

@narekhovhannisyan narekhovhannisyan self-assigned this May 1, 2024
@narekhovhannisyan narekhovhannisyan linked an issue May 1, 2024 that may be closed by this pull request
👍🏼 Update IF to dump logs and errors to yaml file #592
Closed
5 tasks
jmcook1186
jmcook1186 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Checked out the branch locally and confirmed that the expected error message is captured in execution/error and status is set of fail int he case of a failing manifest.
Pass to QA check!

@narekhovhannisyan
Copy link
Member Author

fixes #701

@narekhovhannisyan
Copy link
Member Author

fixes #698

This was referenced May 12, 2024
Closed
Closed
@MariamKhalatova MariamKhalatova merged commit cbfadfd into main May 12, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the dump-logs-errors branch May 12, 2024 19:50
This was referenced May 17, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
Closed
@narekhovhannisyan narekhovhannisyan mentioned this pull request Jun 11, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak Awaiting requested review from manushak

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

👍🏼 Update IF to dump logs and errors to yaml file
3 participants
@narekhovhannisyan @jmcook1186 @MariamKhalatova