Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename global-config to config #963

Merged
merged 14 commits into from
Aug 19, 2024
Merged

Rename global-config to config #963

merged 14 commits into from
Aug 19, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • after getting a review for this PR, I'm going to rename the GlobalConfigError custom of if-core

@manushak manushak self-assigned this Aug 12, 2024
@manushak manushak linked an issue Aug 12, 2024 that may be closed by this pull request
5 tasks
Base automatically changed from node-config to main August 13, 2024 08:11
@manushak manushak merged commit f3f0bd5 into main Aug 19, 2024
2 checks passed
@manushak manushak deleted the rename-global-config branch August 19, 2024 08:11
This was referenced Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update builtins with node-level config to use global scope config
3 participants