From fa1f5f840e1ecd7df9f576f9cab5f6d200acd102 Mon Sep 17 00:00:00 2001
From: Daniel Weber <danielcweber@users.noreply.github.com>
Date: Tue, 26 Mar 2024 14:39:26 +0100
Subject: [PATCH] Fix: Pool settings were lost after configuring the base
 factory.

---
 src/Providers.Core/Factory/GremlinqClientFactory.cs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/Providers.Core/Factory/GremlinqClientFactory.cs b/src/Providers.Core/Factory/GremlinqClientFactory.cs
index 408af73522..911a02fe58 100644
--- a/src/Providers.Core/Factory/GremlinqClientFactory.cs
+++ b/src/Providers.Core/Factory/GremlinqClientFactory.cs
@@ -158,11 +158,7 @@ public void Dispose()
             private readonly int _maxInProcessPerConnection;
             private readonly Func<IGremlinqClient, IGremlinQueryEnvironment, IGremlinqClient> _clientTransformation;
 
-            public PoolGremlinqClientFactory(TBaseFactory baseFactory) : this(baseFactory, 8, 16, static (client, _) => client)
-            {
-            }
-
-            private PoolGremlinqClientFactory(TBaseFactory baseFactory, int poolSize, int maxInProcessPerConnection, Func<IGremlinqClient, IGremlinQueryEnvironment, IGremlinqClient> clientTransformation)
+            public PoolGremlinqClientFactory(TBaseFactory baseFactory, int poolSize, int maxInProcessPerConnection, Func<IGremlinqClient, IGremlinQueryEnvironment, IGremlinqClient> clientTransformation)
             {
                 _poolSize = poolSize;
                 _baseFactory = baseFactory;
@@ -170,7 +166,7 @@ private PoolGremlinqClientFactory(TBaseFactory baseFactory, int poolSize, int ma
                 _maxInProcessPerConnection = maxInProcessPerConnection;
             }
 
-            public IPoolGremlinqClientFactory<TNewBaseFactory> ConfigureBaseFactory<TNewBaseFactory>(Func<TBaseFactory, TNewBaseFactory> transformation) where TNewBaseFactory : IGremlinqClientFactory => new PoolGremlinqClientFactory<TNewBaseFactory>(transformation(_baseFactory));
+            public IPoolGremlinqClientFactory<TNewBaseFactory> ConfigureBaseFactory<TNewBaseFactory>(Func<TBaseFactory, TNewBaseFactory> transformation) where TNewBaseFactory : IGremlinqClientFactory => new PoolGremlinqClientFactory<TNewBaseFactory>(transformation(_baseFactory), _poolSize, _maxInProcessPerConnection, _clientTransformation);
 
             public IPoolGremlinqClientFactory<TBaseFactory> WithMaxInProcessPerConnection(int maxInProcessPerConnection) => maxInProcessPerConnection is > 0 and <= 64
                 ? new PoolGremlinqClientFactory<TBaseFactory>(_baseFactory, _poolSize, maxInProcessPerConnection, _clientTransformation)
@@ -243,7 +239,7 @@ public static TClientFactory ConfigureClient<TClientFactory>(this TClientFactory
             where TClientFactory : IGremlinqClientFactory<TClientFactory> => clientFactory.ConfigureClient((client, _) => clientTransformation(client));
 
         public static IPoolGremlinqClientFactory<TBaseFactory> Pool<TBaseFactory>(this TBaseFactory baseFactory)
-            where TBaseFactory : IGremlinqClientFactory => new PoolGremlinqClientFactory<TBaseFactory>(baseFactory);
+            where TBaseFactory : IGremlinqClientFactory => new PoolGremlinqClientFactory<TBaseFactory>(baseFactory, 8, 16, static (client, _) => client);
 
         public static TClientFactory Log<TClientFactory>(this TClientFactory clientFactory)
             where TClientFactory : IGremlinqClientFactory<TClientFactory> => clientFactory.ConfigureClient((client, environment) => client.Log(environment));