Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports query timezone setting #405

Closed
killme2008 opened this issue Jan 23, 2024 · 2 comments · Fixed by #414
Closed

Supports query timezone setting #405

killme2008 opened this issue Jan 23, 2024 · 2 comments · Fixed by #414
Assignees
Labels
enhancement New feature or request

Comments

@killme2008
Copy link

killme2008 commented Jan 23, 2024

After this patch GreptimeTeam/greptimedb#3125, GreptimeDB already supports timezone setting for HTTP/gRPC protocols.

It's better that the dashboard could support this setting, and the users can use the setting to specify the query timezone.

The HTTP protocol can carry the timezone by the x-greptime-timezone header, and all the timezone strings can be found at Wikipedia https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

But I think we can just support the timezone in the form of [+-]hh:mm, for example, +08:00 or -08:00.

The related issue is GreptimeTeam/greptimedb#2907

@killme2008
Copy link
Author

Considering daylight saving time, we should support the timezone string too. The fixed offset can't cover the daylight saving time.

@ZonaHex ZonaHex added the enhancement New feature or request label Jan 24, 2024
@killme2008
Copy link
Author

This feature needs to be prioritized as the timezone setting affects query results. And we can set the default timezone by retrieving the timezone info from browser settings if possible. @ZonaHex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants