Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build greptimedb for using centos based builder image #3401

Closed
zyy17 opened this issue Feb 28, 2024 · 3 comments · Fixed by #3402
Closed

Failed to build greptimedb for using centos based builder image #3401

zyy17 opened this issue Feb 28, 2024 · 3 comments · Fixed by #3402
Labels
C-bug Category Bugs

Comments

@zyy17
Copy link
Collaborator

zyy17 commented Feb 28, 2024

What type of bug is this?

Other

What subsystems are affected?

Other

Minimal reproduce step

The PR #3394 uses the option --retry-connrefused of curl to fetch dashboard assets, however, the current builder image greptime/dev-builder-centos:latest doesn't have the option because of using the old version curl:

docker run docker.io/greptime/dev-builder-centos:latest curl --retry-connrefused https://example.com

The building log: https://github.com/GreptimeTeam/greptimedb/actions/runs/8073087585/job/22056213664.

What did you expect to see?

Build greptimedb of centos successfully.

What did you see instead?

N/A

What operating system did you use?

macOS

What version of GreptimeDB did you use?

latest

Relevant log output and stack trace

No response

@zyy17 zyy17 added the C-bug Category Bugs label Feb 28, 2024
@zyy17
Copy link
Collaborator Author

zyy17 commented Feb 28, 2024

cc @tisonkun

@zyy17
Copy link
Collaborator Author

zyy17 commented Feb 28, 2024

IMO, Some solutions:

  1. Upgrade curl for dev-builder-centos: I'm not sure whether it is an easy thing to upgrade the package for the legacy image;
  2. Refactor the download script: If --retry-connrefused is necessary, maybe we can change another shell way to reach that. The main command can use the basic option of curl for the compatibility;

@tisonkun
Copy link
Collaborator

Yeah. This flag is available since curl 7.52.0. We can quickly workaround it by drop this flag. Or let me take a look if we can have a modern curl in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category Bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants