Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the UDAF implementation under the new DataFusion #3666

Closed
MichaelScofield opened this issue Apr 8, 2024 · 1 comment · Fixed by #3814
Closed

Rewrite the UDAF implementation under the new DataFusion #3666

MichaelScofield opened this issue Apr 8, 2024 · 1 comment · Fixed by #3814

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Other

What does the enhancement do?

The new DataFusion deprecates how its UDAF can be written before, specifically the AggregateUDF::new:

impl AggregateUDF {
    /// Create a new AggregateUDF
    ///
    /// See  [`AggregateUDFImpl`] for a more convenient way to create a
    /// `AggregateUDF` using trait objects
    #[deprecated(since = "34.0.0", note = "please implement AggregateUDFImpl instead")]
    pub fn new(
        name: &str,
        signature: &Signature,
        return_type: &ReturnTypeFunction,
        accumulator: &AccumulatorFactoryFunction,
        state_type: &StateTypeFunction,
    ) -> Self {

We should use the new implementation once #3661 is merged.

Implementation challenges

No response

@tisonkun
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants