Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sort within each PartitionRange #4847

Merged
merged 14 commits into from
Oct 23, 2024
Merged

feat: Sort within each PartitionRange #4847

merged 14 commits into from
Oct 23, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Oct 17, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • add a physical plan that sort within each PartitionRange boundary marked by empty RecordBatch
  • add fuzzy(ish) test for it

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 17, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.45188% with 103 lines in your changes missing coverage. Please review.

Project coverage is 83.99%. Comparing base (613e07a) to head (da68a7b).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4847      +/-   ##
==========================================
- Coverage   84.30%   83.99%   -0.32%     
==========================================
  Files        1127     1131       +4     
  Lines      208553   208879     +326     
==========================================
- Hits       175814   175439     -375     
- Misses      32739    33440     +701

evenyag
evenyag reviewed Oct 21, 2024
View reviewed changes
src/query/src/window_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
evenyag
evenyag reviewed Oct 22, 2024
View reviewed changes
src/query/src/window_sort.rs Outdated Show resolved Hide resolved
src/query/src/window_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
evenyag
evenyag approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

src/query/src/part_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
src/query/src/part_sort.rs Outdated Show resolved Hide resolved
@waynexia waynexia added this pull request to the merge queue Oct 23, 2024
Merged via the queue into GreptimeTeam:main with commit 0c01532 Oct 23, 2024
33 checks passed
@evenyag evenyag mentioned this pull request Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@discord9 @evenyag @waynexia