-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor refactor for weighted choose #4917
chore: minor refactor for weighted choose #4917
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4917 +/- ##
==========================================
- Coverage 84.19% 83.92% -0.28%
==========================================
Files 1137 1137
Lines 209796 210032 +236
==========================================
- Hits 176646 176272 -374
- Misses 33150 33760 +610 |
f3a1e69
to
3cbdcf0
Compare
3cbdcf0
to
1ba9ff2
Compare
The choose_multiple method in the WeightedChoose trait does not clearly state whether duplicate items are allowed to be returned, which may cause some confusion. cc @WenyXu |
It wouldn't by default, let's add some comments. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As the title.
Checklist