Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful Exception Handling #5

Open
Griffintaur opened this issue Aug 13, 2017 · 6 comments
Open

Graceful Exception Handling #5

Griffintaur opened this issue Aug 13, 2017 · 6 comments

Comments

@Griffintaur
Copy link
Owner

Exceptions should be handled gracefully and should display proper proper message

@ashoka-tech
Copy link

ashoka-tech commented Aug 14, 2017

Hi Griffintaur, I am a first time contributor trying out OSS contribution.. Could you please let me know what I should do to take this issue and fix it? I dont want to be lazy, just provide some pointers and I can do the rest
Thanks in advance!

@Griffintaur
Copy link
Owner Author

Hi @ashoka-tech, thanks for your interest in our project. If you look into the source code, you will find that in most of the places we are catching the general exception.
Now, we want to catch the specialized exception and document it and add a trace for the developer.
Please ask questions if there is any confusion or need clarifications.

@Rosedoge
Copy link

Rosedoge commented Oct 4, 2018

Oh I'd like to give a crack at this :3

@Griffintaur
Copy link
Owner Author

@Rosedoge Cool

@Heacien
Copy link

Heacien commented Apr 23, 2019

I'm new to contributing too and I can't even compile the project locally

vs error

Any hints on how to get it working?

@Griffintaur
Copy link
Owner Author

Sorry, was busy will have a look and let you know. But looking at the errors, it seems MediaPlayerMainViewModel is not instantiated/accessible in the main view model i.e media player view model. Please have a look if the MediaPlayerMainViewmodel object is accessible or not.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants