feat: Support Interfaces #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2019 23:36
rtymchyk
commented
Sep 18, 2019
| @@ -29,7 +29,7 @@ def to_graphql | |||
| end | |||
|
|
|||
| possible_entities = orig_defn.types.values.select do |type| | |||
| !type.introspection? && !type.default_scalar? && | |||
| !type.introspection? && !type.default_scalar? && type.is_a?(GraphQL::ObjectType) && | |||
There was a problem hiding this comment.
added 3 commits
October 4, 2019 17:44
|
Sorry for the delay. I've been out on parental leave for the last few weeks. I'll take a look at this next week. |
|
Thank you for the update 🙂 |
rylanc
suggested changes
Oct 21, 2019
rylanc
approved these changes
Oct 22, 2019
rylanc
pushed a commit
that referenced
this pull request
Oct 22, 2019
# [0.5.0](v0.4.2...v0.5.0) (2019-10-22) ### Features * Support Interfaces ([#27](#27)) ([33d0097](33d0097))
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the spec defined in: https://www.apollographql.com/docs/apollo-server/federation/federation-spec/
Notes:
directive @extends on OBJECT | INTERFACEdirective @key(fields: _FieldSet!) on OBJECT | INTERFACE-> Introduce a new
ApolloFederation::Interfacemodule that can be included in base interface modules, using the API outlined in https://graphql-ruby.org/type_definitions/interfaces#definition-methodsunion _EntityUnions cannot reference interface types, so the resolver excludes non-object types to generate this field.