Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profile sync): force copy if sync_mode is overwirte #555

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jmkerloch
Copy link
Collaborator

@jmkerloch jmkerloch commented Sep 5, 2024

closes #531

related #519

When sync_mode was overwirte we were still making merge to get new values for .ini.

Now in overwrite mode, a copy is done.

@jmkerloch jmkerloch requested a review from Guts September 5, 2024 11:53
@jmkerloch jmkerloch self-assigned this Sep 5, 2024
@jmkerloch jmkerloch added the bug Something isn't working label Sep 5, 2024
@github-actions github-actions bot added the jobs Scenarios and jobs label Sep 5, 2024
@jmkerloch jmkerloch added this to the 0.35.2 milestone Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (0e4e6d1) to head (3b9ff5a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   71.10%   71.00%   -0.10%     
==========================================
  Files          47       47              
  Lines        3135     3135              
  Branches      671      671              
==========================================
- Hits         2229     2226       -3     
- Misses        716      718       +2     
- Partials      190      191       +1     
Flag Coverage Δ
unittests 70.43% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...loyment_toolbelt/jobs/job_profiles_synchronizer.py 41.23% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jmkerloch jmkerloch marked this pull request as draft September 5, 2024 12:25
@jmkerloch jmkerloch force-pushed the fix/overwrite-option-jobs-synchronizer branch from 4bc2d2d to 3aad5ac Compare September 5, 2024 14:14
Copy link
Collaborator

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀!

@Guts Guts modified the milestones: 0.35.2, 0.35.3 Sep 5, 2024
@jmkerloch jmkerloch marked this pull request as ready for review September 5, 2024 15:21
@jmkerloch jmkerloch force-pushed the fix/overwrite-option-jobs-synchronizer branch from 574239f to 3b9ff5a Compare September 6, 2024 09:17
Copy link

sonarcloud bot commented Sep 6, 2024

@jmkerloch jmkerloch merged commit a9ad61d into main Sep 6, 2024
25 checks passed
@jmkerloch jmkerloch deleted the fix/overwrite-option-jobs-synchronizer branch September 6, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: overwrite ne fonctionne que partiellement
3 participants