Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull avatar-related messages into their own plAvatarMessages project #1410

Open
dpogue opened this issue Jun 26, 2023 · 0 comments
Open

Pull avatar-related messages into their own plAvatarMessages project #1410

dpogue opened this issue Jun 26, 2023 · 0 comments

Comments

@dpogue
Copy link
Member

dpogue commented Jun 26, 2023

A lot of the avatar messages have dependencies on things from plAvatar (like plAvatarMgr) and that brings in a bunch of FeatureLib dependencies.

Once upon a time, it seemed possible to compile with a NO_AV_MSGS define to exclude the avatar-related messages for tools, but changing that between build targets would be super inconvenient.

My suggestion is to create a new PubUtilLib project and move the avatar messages there, and then update the things that actually use those messages to link against it. We might need to leave a few messages in plMessage if they are widely used, but stuff that involves plAvBrains and plAvTasks should be split out.

(Brought to you by my attempt to compile plFontConverter in mingw failing because of PhysX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant