Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Caps Lock does not turn on running #1599

Closed
dpogue opened this issue Jul 6, 2024 · 2 comments · Fixed by #1601
Closed

[macOS] Caps Lock does not turn on running #1599

dpogue opened this issue Jul 6, 2024 · 2 comments · Fixed by #1601
Assignees

Comments

@dpogue
Copy link
Member

dpogue commented Jul 6, 2024

Turning Caps Lock on and off does not affect the movement speed on macOS. Holding Shift to run works fine.

The bit of extra complexity here is detecting the caps lock state on startup, and monitoring for changes to caps lock state while Uru does not have focus, but it seems like Cocoa events provide ways to do that.

@colincornaby
Copy link
Contributor

I'll take a look.

This also reminds me that there is an open question of optionally adopting the Game Controller framework on newer versions - which provides a more sane interface for games to get keyboard input. This would also be required for iOS/visionOS.

We'd need this code path for older macOS versions though. So I'll look at patching this path.

@dpogue
Copy link
Member Author

dpogue commented Jul 9, 2024

The fix in #1601 works well enough for me to consider this closed.

@dpogue dpogue linked a pull request Jul 9, 2024 that will close this issue
@dpogue dpogue closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants