Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct line numbering on parsing error in log #787

Open
matsekberg opened this issue Aug 27, 2024 · 1 comment
Open

Correct line numbering on parsing error in log #787

matsekberg opened this issue Aug 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@matsekberg
Copy link

Is your feature request related to a problem? Please describe.
When having parsing errors in the page jsonl it is very nice to be able to look in the serial log and find out what line the error is on.
It seems as if blank lines are skipped and the line number references are wrong if the file contains blank lines.

Describe the solution you'd like
When parsing, do count the blank lines also.

Describe alternatives you've considered
Sorry no other options :)

Additional context
Nope

@matsekberg matsekberg added the enhancement New feature or request label Aug 27, 2024
@fvanroie
Copy link
Collaborator

fvanroie commented Sep 25, 2024

The parsing happens object by object, so it is actually the object number instead of line number.
The library doing the parsing doesn't report on blank lines, only on JSON objects encountered.
I'm not sure if showing the object number instead of line number is more helpful...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants