Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: with screen off, first touch should just wake screen #80

Closed
nagyrobi opened this issue Mar 6, 2021 · 9 comments
Closed
Assignees
Labels
done The underlying issue has been fixed enhancement New feature or request

Comments

@nagyrobi
Copy link
Collaborator

nagyrobi commented Mar 6, 2021

After Long Idle, screen turns off. If I touch the screen to wake it, the object underneath will also react. This is a problem as the user might touch in the wrong area without first seeing the screen, causing undesired effects.

It would be nice to have an option/setting which enabled, at touch would check first if the screen is off and if it is, just wake it and exit routine/function without touching the objects.

@nagyrobi nagyrobi added the enhancement New feature or request label Mar 6, 2021
@fvanroie fvanroie self-assigned this Mar 8, 2021
@fvanroie
Copy link
Collaborator

fvanroie commented Mar 8, 2021

This request has come up before and will be included in one way or another...

@fvanroie
Copy link
Collaborator

fvanroie commented Mar 9, 2021

This is now implemented in the 0.4.0-dev branch.

@nagyrobi
Copy link
Collaborator Author

Works, excellent, thank you!

@nagyrobi
Copy link
Collaborator Author

No it doesn't... so reopening...

@nagyrobi nagyrobi reopened this Mar 14, 2021
@fvanroie
Copy link
Collaborator

fvanroie commented Mar 16, 2021

Are you setting dim to 0 instead of setting light to off?

The wakeup touch enables the backlight, so reverting to the previous dim level.
If the dim level is 0, the backlight will 'turn on' to the level 0...

@nagyrobi
Copy link
Collaborator Author

No that's not the problem. The problem is that if I touch the screen it wakes up normally, but it also clicks the object.

@fvanroie
Copy link
Collaborator

Wakeup touch is only enabled/disabled when using light off/on commands. You should see it appear in the log:

image

It seems you are just setting dim to 0, which will not enable wakeup touch.

@fvanroie
Copy link
Collaborator

Is this still an issue?

@nagyrobi
Copy link
Collaborator Author

Hopefully not. I expeience strange touch things occasionally but i think not related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done The underlying issue has been fixed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants