From 3df386acca806d652bbe2209f7c4503b30f068ff Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Thu, 29 Apr 2021 20:36:08 -0700 Subject: [PATCH] Updates the RELEASE.txt note --- release_docs/RELEASE.txt | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index d2b239b1362..22ad208e850 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -414,21 +414,19 @@ New Features Library: -------- - - H5Gcreate1() now rejects size_hint parameters larger than UINT32_MAX + - H5Gcreate1() now handles large size_hint parameters correctly - The size_hint value is ultimately stored in a uint32_t struct field, - so specifying a value larger than this on a 64-bit field can cause - undefined behavior including crashing the system. + On 64-bit systems, large values of the size_t size_hint parameter + would be passed through a uint32_t struct field, causing a crash + on 64-bit Windows w/ MSVC and probably incorrect behavior or crashes + on other 64-bit systems. The documentation for this API call was also incorrect, stating that passing a negative value would cause the library to use a default value. Instead, passing a "negative" value actually passes a very large value, which is probably not what the user intends and can cause crashes on 64-bit systems. - - The Doxygen documentation has been updated and passing values larger - than UINT32_MAX for size_hint will now produce a normal HDF5 error. - + (DER - 2021/04/29, HDFFV-11241)