Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate an independent variable 'value' given as a range of numbers #33

Closed
GraemeWatt opened this issue Aug 20, 2021 · 1 comment · Fixed by #32
Closed

Invalidate an independent variable 'value' given as a range of numbers #33

GraemeWatt opened this issue Aug 20, 2021 · 1 comment · Fixed by #32
Labels

Comments

@GraemeWatt
Copy link
Member

Related to HEPData/hepdata-converter#41, some records have an incorrect YAML encoding such as value: 800 - 1000 (table) or value: '1-1.5' (table) instead of separate low and high values. Such an incorrect YAML encoding gives an acceptable table rendering and is properly handled by the visualisation code, so it could easily be missed in the review process. We should therefore invalidate cases where an independent variable value (without low and high values) has the form of two numbers separated by a hyphen (with or without surrounding spaces). This might be possible using the not keyword in the JSON schema. Note that the numbers might be given in scientific notation. If value takes the form of two numbers separated by a hyphen, an error message should be returned asking the user to instead give the range as low and high values.

@GraemeWatt GraemeWatt added the bug label Aug 20, 2021
@alisonrclarke
Copy link
Contributor

Note that the numbers might be given in scientific notation.

Can I check which formats you mean for this? Do you just programming-style formats e.g. 1.3e7 or 4.2E-9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants