Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ensure user is only created/modified, if update works as well and data is correct #13

Open
AndreasA opened this issue Mar 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@AndreasA
Copy link
Contributor

AndreasA commented Mar 8, 2023

Plugin Version

4.2.1

PHP Version

8.1

Shopware Version

6.4.18.1

Installation method

Composer

Identity provider

Google Cloud

What happened?

It would probably be a good idea to put the whole user creation / update part in a database transaction with commit/rollback, so only upon success the user created / modified if everything works correctly.

Relevant log output

No response

@JoshuaBehrens
Copy link
Member

That is a good input. For this we need to validate, that we keep everything in that transaction. It is unlikely that we provide an update for the Shopware 6.4 plugin version as we are in a refactoring process for Shopware 6.5. But we keep that in mind in our refactoring, that we make this safer in its process.

@JoshuaBehrens JoshuaBehrens added the enhancement New feature or request label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants