Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the bin_frames option from find-orientations #551

Open
psavery opened this issue Jul 25, 2023 · 1 comment
Open

Remove the bin_frames option from find-orientations #551

psavery opened this issue Jul 25, 2023 · 1 comment
Labels
question Further information is requested

Comments

@psavery
Copy link
Collaborator

psavery commented Jul 25, 2023

This option is not used anymore. We can remove it from the code.

Maybe we should print a warning if it is present that it is not used.

@gustafsonsven
Copy link
Collaborator

@psavery Is this implemented beyond having an option in the configuration? I can imagine some edge case scenarios that bin frames would be useful in fitting; however, it would be fairly low priority to add such an option if not already implemented.

@ZackAttack614 ZackAttack614 added the question Further information is requested label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants