Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement frame-by-frame energy correction for fit-grains #600

Open
psavery opened this issue Jan 9, 2024 · 0 comments
Open

Implement frame-by-frame energy correction for fit-grains #600

psavery opened this issue Jan 9, 2024 · 0 comments
Labels
HEDM issues pertaining the HEDM workflow high priority move these to the top of the stack

Comments

@psavery
Copy link
Collaborator

psavery commented Jan 9, 2024

We can keep using the current beam energy in the instrument class as an "average" beam energy. Most parts of HEXRD will work fine with this average beam energy. For example, for the indexing step, it is probably okay to use the average beam energy.

However, for fit grains, we also want to perform frame-by-frame correction based upon the different energies of each frame. We should look into how we might be able to take into account this list of energies for fit-grains, without having to refactor major parts of the code. Perhaps one step would be to add an argument to simulate_rotation_series() with the beam energy list. That might even be enough for all of pull_spots() to work...

See discussion in #592.

@psavery psavery added the HEDM issues pertaining the HEDM workflow label Jan 9, 2024
@ZackAttack614 ZackAttack614 added the high priority move these to the top of the stack label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HEDM issues pertaining the HEDM workflow high priority move these to the top of the stack
Projects
None yet
Development

No branches or pull requests

2 participants