Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if compile args are being used by Windows #612

Closed
psavery opened this issue Jan 30, 2024 · 2 comments · Fixed by #706
Closed

Check if compile args are being used by Windows #612

psavery opened this issue Jan 30, 2024 · 2 comments · Fixed by #706
Assignees
Labels
HEDM issues pertaining the HEDM workflow testing

Comments

@psavery
Copy link
Collaborator

psavery commented Jan 30, 2024

These compile arguments are in a gcc-like format. But it looks like they are also being passed to the Visual Studio compiler. I have a feeling that Visual Studio might just be ignoring them. We should verify that Visual Studio is using these compiler arguments correctly.

@psavery psavery added the HEDM issues pertaining the HEDM workflow label Jan 30, 2024
@kevindlewis23
Copy link
Collaborator

They are ignored, I saw this in the pip install output

  cl : Command line warning D9002 : ignoring unknown option '-O3'
  cl : Command line warning D9002 : ignoring unknown option '-shared'
  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
  cl : Command line warning D9002 : ignoring unknown option '-funroll-loops'

@psavery
Copy link
Collaborator Author

psavery commented Aug 9, 2024

Yeah, I think we need to branch the logic for compiler options so Windows will only receive what it will actually use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HEDM issues pertaining the HEDM workflow testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants