Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when HKL Exclusion Options are Ignored #615

Open
psavery opened this issue Feb 7, 2024 · 0 comments
Open

Clarify when HKL Exclusion Options are Ignored #615

psavery opened this issue Feb 7, 2024 · 0 comments
Assignees
Labels
cleanup low priority low priority task

Comments

@psavery
Copy link
Collaborator

psavery commented Feb 7, 2024

There are a lot of HKL exclusion options now, and many times, some of them are being ignored. I think we need to make it very clear when they are ignored, because it is very confusing to users otherwise. The clearest way is to raise an exception and force the user to rewrite their config until it doesn't contain any ignored settings.

For example, if fit-grains is ran with the default reset_exclusions: True, all HKL exclusion options in the material config will have no effect, because the HKLs will be reset again later in fit-grains. If the user sets any exclusion options in the material config, we should make it clear to them that it has no effect. We probably want to raise an exception.

Another example: if reset_exclusions: False is set, but other HKL exclusions options are also set, then we should also raise an exception, because those options will have no effect.

Also, if we set both tthmax and tth_max, an exception should be raised because tth_max will be ignored. Same kind of thing with min_sfac_ratio and sfacmin.

@darrencpagan Feel free to provide additional feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup low priority low priority task
Projects
None yet
Development

No branches or pull requests

3 participants