Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially Unused Function _gvec_to_detector_array #658

Open
ZackAttack614 opened this issue Jun 28, 2024 · 3 comments
Open

Potentially Unused Function _gvec_to_detector_array #658

ZackAttack614 opened this issue Jun 28, 2024 · 3 comments

Comments

@ZackAttack614
Copy link
Collaborator

The function's documentation claims to be identical to gvec_to_xy from the transforms module, but worse. It also doesn't seem to be used in all of hexrd.

Consider deletion.
@psavery
Copy link
Collaborator

psavery commented Jul 1, 2024

The scripts in the grainmap directory are near-field scripts maintained by Darren Pagan and Rachel Lim.

I think we should consider moving these scripts to a separate directory (like scripts/grainmap), since these are not really used as a part of the hexrd package. We should also probably ask for their review for deleting anything.

@psavery psavery mentioned this issue Jul 1, 2024
Closed
@ZackAttack614
Copy link
Collaborator Author

Since the scripts folder has now been removed, should we consider deleting this from the repo and moving it elsewhere? Happy to include Darren/Rachel as appropriate.

@ZackAttack614
Copy link
Collaborator Author

@darrencpagan Can you advise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZackAttack614 @psavery