Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve masked regions preview #1654

Open
bnmajor opened this issue Jan 24, 2024 · 2 comments
Open

Improve masked regions preview #1654

bnmajor opened this issue Jan 24, 2024 · 2 comments

Comments

@bnmajor
Copy link
Collaborator

bnmajor commented Jan 24, 2024

Pulled from the comments in a previous issue we should make the following improvements;

  1. Make subplots use the same range for coloring. Right now subplots with masked regions have 1 as yellow and 0 as purple whereas unmasked images have 1 as purple
  2. Support polar and/or stereograph views since this is how it is commonly presented at meetings, etc.
    1. Instead of raw use only polar? -OR-
    2. Ability to toggle between views like with image data? -OR-
    3. Use the view that matches the current image mode?
@psavery
Copy link
Collaborator

psavery commented Jan 25, 2024

They sound good! I think that for 2, we can use the view that matches the current image mode.

However, since we don't support masking in the Cartesian view, maybe we should just display a raw view of the masks for that one? We can put in text at the top of the dialog what view is being used to generate the masks, for clarity.

One extra reason for doing it this way: we currently generate the threshold mask for the polar view after the polar view has been generated. So we would need the generated polar view to accurately display the threshold mask in the polar view.

@bnmajor
Copy link
Collaborator Author

bnmajor commented Jan 25, 2024

This sounds great, thanks @psavery!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants