[TTAHUB-3614] Use materialized view for finding goals from replaced grants (activity report goals handler) #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvms
changed the title
nvms
requested review from
thewatermethod,
hardwarehuman,
GarrettEHill,
kryswisnaskas and
AdamAdHocTeam
GarrettEHill
approved these changes
Nov 25, 2024
AdamAdHocTeam
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The handler that grabbed goals for ARs did not use the new materialized view, which means goals from replaced grants were not surfaced in the UI. This simple change fixes that.
The result is that when the old goal is used on the new grant, and the AR is approved, an entirely new goal is created referencing the new grant ID.
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy