Fix issue koppor/jabref#521 (Add feature: allow drag&drop from selected bib entries to other library tabs) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d3573c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#5988) 5de0fbe Update society-of-biblical-literature-fullnote-bibliography.csl (JabRef#5913) 04b6c7a Create revue-internationale-durbanisme.csl (JabRef#5974) 4a5bfe2 Update biological-reviews.csl (JabRef#6116) 957b2bc Update harvard-cite-them-right-no-et-al.csl (JabRef#6115) e836a6c Update harvard-university-of-bath.csl (JabRef#6011) b4a8dd7 Update and rename harvard-cite-them-right.csl to harvard-cite-them-ri… (JabRef#6113) a198884 Update twentieth-century-music.csl (JabRef#6110) 81c1619 Update archaeonautica.csl (JabRef#5928) fc46f1d Bump actions/cache from 2 to 3 (JabRef#6112) fab57ed Bump actions/checkout from 2 to 3 (JabRef#6111) 519d594 [don't merge] chore: Included githubactions in the dependabot config (JabRef#6109) a8aa898 Update universidade-estadual-de-alagoas-uneal-abnt.csl (JabRef#5915) 6191640 Update isnad-dipnotlu.csl (JabRef#5909) d65a6ac Update isnad-metinici.csl (JabRef#5910) 830d337 Update technische-universitat-dresden-linguistik.csl (JabRef#6097) 81adc43 Update american-society-for-horticultural-science.csl (JabRef#6089) b767623 Create south-african-law-journal.csl (JabRef#6092) 215e1e9 Create journal-of-lithic-studies.csl (JabRef#6080) 0740f8c Create eunomia-revista-en-cultura-de-la-legalidad.csl (JabRef#6095) f93c809 Create endocrine-journal.csl (JabRef#6086) 3fdeb51 Revert "chore: Set permissions for GitHub actions (JabRef#6096)" (JabRef#6108) 35ebd1e chore: Set permissions for GitHub actions (JabRef#6096) 1cb8758 Create journal-fur-medienlinguistik (JabRef#6100) f4b5f7f Update unified-style-sheet-for-linguistics.csl (JabRef#6098) c3f856a Update advanced-materials.csl (JabRef#6103) d1e7576 Bump diffy from 3.4.0 to 3.4.2 (JabRef#6107) 9e5e7ab Fix Dev Dynamics (JabRef#6099) 7234520 Add CSL style for the journal Developmental Dynamics (JabRef#6093) ba8db05 Create independent style for vox-sanguinis.csl (JabRef#6085) 845dee0 Create meta.csl (JabRef#6088) 684bc3a Update universite-du-quebec-a-montreal.csl (JabRef#6087) 3602c18 Up-date & re-title pour-reussir/dionne (JabRef#6043) 0cc6e82 Fix Mainz Geography cfc4cec Add DOI and fix printing author names in Population and Économie et statistique (JabRef#6079) 14e8b1d Update journal-of-neuroimaging.csl (JabRef#6084) 2c0e1f1 Update isnad-dipnotlu.csl (JabRef#6081) 02fdb9b Merge pull request JabRef#6082 from denismaier/patch-ube-muwi-note 9309378 removes default-locale git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 3d3573c
55459cd79f copied .github/workflows/merge.yaml .github/workflows/sheldon.yaml from styles 63eed7b271 copied .github/workflows/merge.yaml .github/workflows/sheldon.yaml from styles 39e1b29d16 copied .github/workflows/sheldon.yaml from styles 1b0a9d2f12 copied .github/workflows/sheldon.yaml from styles 9c4984cabd Merge pull request JabRef#261 from citation-style-language/dependabot/bundler/diffy-3.4.2 21387b3689 Bump diffy from 3.4.0 to 3.4.2 git-subtree-dir: buildres/csl/csl-locales git-subtree-split: 55459cd79fa909bd0a11da509f109b2ddf4726e5
[Bot] Update CSL styles
Bumps [mariadb-java-client](https://github.com/mariadb-corporation/mariadb-connector-j) from 2.7.5 to 2.7.6. - [Release notes](https://github.com/mariadb-corporation/mariadb-connector-j/releases) - [Changelog](https://github.com/mariadb-corporation/mariadb-connector-j/blob/2.7.6/CHANGELOG.md) - [Commits](mariadb-corporation/mariadb-connector-j@2.7.5...2.7.6) --- updated-dependencies: - dependency-name: org.mariadb.jdbc:mariadb-java-client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.1 to 10.3.1. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.1...checkstyle-10.3.1) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.1 to 10.3.1. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.1...checkstyle-10.3.1) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
…bib file (JabRef#8840) * Change from error dialog to warning dialog when no suitable import format. Also add more meaningful message when warning occurred. * remove Localization.lang() on parserResult.getErrorMessage() * Update error messages for source tab and importing library file * Update error message for opening library file * Update Localization lang
* Refactored * extract entrytypesmanager * checkstyle Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
Bumps [jsoup](https://github.com/jhy/jsoup) from 1.15.1 to 1.15.2. - [Release notes](https://github.com/jhy/jsoup/releases) - [Changelog](https://github.com/jhy/jsoup/blob/master/CHANGES) - [Commits](jhy/jsoup@jsoup-1.15.1...jsoup-1.15.2) --- updated-dependencies: - dependency-name: org.jsoup:jsoup dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.8.147 to 4.8.149. - [Release notes](https://github.com/classgraph/classgraph/releases) - [Commits](classgraph/classgraph@classgraph-4.8.147...classgraph-4.8.149) --- updated-dependencies: - dependency-name: io.github.classgraph:classgraph dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix charset detection with utf16 and others Fixes JabRef#8895 Fixes JabRef#8870 * checkstyöe * Fix typo in method names * change newlines * get bytes * Set newline character to LF * Revert "get bytes" This reverts commit 1082f8a. * progress * switch line sep to LF * Please work * Try jitpack * Add manual build of icu4j * Check if we have ascii in the list of charsets * fix checkstyle * Update external-libraries.md * Enocde with UTF-16BE * Fix umlaut * Hack to get test running * Also compare meta data * Add enforced ignorance of malformed characters Source: http://biercoff.com/malformedinputexception-input-length-1-exception-solution-for-scala-and-java/ Co-authored-by: Christoph <siedlerkiller@gmail.com> * checkstyle * IntelliJ now also renders the file correctly * Add test Additionally - Replace unknown characters - Remove obsolete wrapping classes in test * Refine CHANGELOG.md * Remove non-working jpackage reference Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Houssem Nasri <housi.housi2015@gmail.com>
* New translations JabRef_en.properties (Chinese Simplified) * New translations JabRef_en.properties (Italian) * New translations JabRef_en.properties (German) * New translations JabRef_en.properties (Russian)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // It is necessary to setOnDragOver for newly opened tabs | ||
| tabbedPane.lookupAll(".tab").forEach(t -> { | ||
| t.setOnDragOver(tabDragEvent -> { | ||
| if(tabDragEvent.getDragboard().hasContent(DragAndDropDataFormats.ENTRIES)) |
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
'if' is not followed by whitespace.
| tabbedPane.lookupAll(".tab").forEach(t -> { | ||
| t.setOnDragOver(tabDragEvent -> { | ||
| if(tabDragEvent.getDragboard().hasContent(DragAndDropDataFormats.ENTRIES)) | ||
| { |
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.blocks.LeftCurlyCheck> reported by reviewdog 🐶
'{' at column 25 should be on the previous line.
| @@ -758,6 +762,11 @@ public void paste() { | |||
| mainTable.paste(); | |||
| } | |||
|
|
|||
| public void dropEntry(List<BibEntry> entriesToAdd) | |||
| { | |||
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.blocks.LeftCurlyCheck> reported by reviewdog 🐶
'{' at column 5 should be on the previous line.
| @@ -314,6 +314,13 @@ public void paste() { | |||
| } | |||
| } | |||
|
|
|||
| public void dropEntry(List<BibEntry> entriesToAdd) | |||
| { | |||
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.blocks.LeftCurlyCheck> reported by reviewdog 🐶
'{' at column 5 should be on the previous line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue#521 from koppor/jabref issue tracker, we added new feature about allowing drag selected entries, and drop them to other opened inactive bib library tabs.
Behavior Description:
Now when dragging selected entries in main table, JabRef allows user to drop it on another opened library tab, and this item will be copied and added to the dropped library accordingly. Drop to current active tab is disallowed. If there're potential duplicated entries, JabRef will ask user to confirm and choose copy behavior (similar to ctrl-c/v copy and paste).
Link issues that are fixed:
Fixed: JabRef#521
Screenshots for UI changes:
![]
Checklist / TODOs :
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)