DT-496 front page push state #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there is a discussion / problem in the rackt/history about pushing the same URL but different state. See issue remix-run/history#178
When closing off-canvas, we use goBack(), so that closing does not go into browser history. There is no "pop" operation exposed, so this is the best we can do for now.
No need to listen to history changes here.
…ront-page-push-state Conflicts: package.json
c1.13.0 doesn't contain pull request #43 which makes push without a location change a pop.
|
Now without fixed/forked history but using instead pinned version 1.13.0 (1.13.1 is already broken). |
optionsome
pushed a commit
that referenced
this pull request
Aug 20, 2021
derhuerst
pushed a commit
to bbnavi/digitransit-ui
that referenced
this pull request
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Had to fix rackt/history. Currently using fork at Macroz/history. See PR remix-run/history#179 and issue remix-run/history#178