Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a type checker and run it with Travis #379

Closed
Mec-iS opened this issue Mar 25, 2019 · 9 comments
Closed

Find a type checker and run it with Travis #379

Mec-iS opened this issue Mar 25, 2019 · 9 comments

Comments

@Mec-iS
Copy link
Contributor

Mec-iS commented Mar 25, 2019

I'm submitting a

  • feature request.

Current Behaviour:

Type annotations with mypy allow the code to tell developers which type of inputs/outputs are expected but there is no tool that checks that the annotations are respected by the functions

Expected Behaviour:

Some command-line tool should run with CI to check if types annotations are correct. See pyre

@Mec-iS
Copy link
Contributor Author

Mec-iS commented Apr 3, 2019

another option: https://github.com/Microsoft/pyright

@de-sh de-sh mentioned this issue Apr 4, 2019
2 tasks
@sameshl
Copy link
Member

sameshl commented Sep 7, 2020

@sjathin Yes, sure. Go ahead!

@priyanshunayan
Copy link
Member

Hi @sjathin! You should no longer face this issue as this was fixed in #500. Can you try running the latest revision of hydrus again?

@sjathin
Copy link

sjathin commented Sep 11, 2020

Hi @priyanshunayan, I do have the latest revision, I am facing this issue.

@priyanshunayan
Copy link
Member

From your logs I can see that you are not inside the virtual environment. Indeed, the documentation is missing this step. I will make sure this gets added in the docs. In meantime please follow following steps before pip install:

  • python3 -m venv venv
  • source venv/bin/activate
  • pip3 install -r requirements.txt

/cc @sjathin

@harshraj22 harshraj22 mentioned this issue Nov 4, 2020
2 tasks
@de-sh
Copy link
Contributor

de-sh commented Nov 11, 2020

Hello folks, I have an interesting opinion about this issue, how about we add a static analyzer such as DeepSource to the CI?

These might be some interesting findings.

@king-11
Copy link
Contributor

king-11 commented Jan 8, 2021

@DARKPROGRAMMER16 you are using the dev branch or the master? coz the issue in dev branch is resolved

@DARKPROGRAMMER16
Copy link

@king-11

I am in dev branch

@Mec-iS
Copy link
Contributor Author

Mec-iS commented Jan 8, 2021

this content is not related to this issue. For any question, first use Slack and search for past issues or Google. If there is no other reference, open a new issue. Please follow Code Contribution rules.

@HTTP-APIs HTTP-APIs deleted a comment from sjathin Jan 8, 2021
@HTTP-APIs HTTP-APIs deleted a comment from sjathin Jan 8, 2021
@HTTP-APIs HTTP-APIs deleted a comment from saif007s Jan 8, 2021
@HTTP-APIs HTTP-APIs deleted a comment from saif007s Jan 8, 2021
@HTTP-APIs HTTP-APIs deleted a comment from DARKPROGRAMMER16 Jan 8, 2021
@Mec-iS Mec-iS closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants