Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes starting with numbers are not valid #355

Open
danmihaila opened this issue Aug 29, 2023 · 2 comments
Open

Attributes starting with numbers are not valid #355

danmihaila opened this issue Aug 29, 2023 · 2 comments
Assignees

Comments

@danmihaila
Copy link
Contributor

We had a file with attributes like "#affected+injured+dineo+2017" - starting with a digit which are not recognized as valid tag. Due to this, the file is marked as not having hxl tags even if it had other valid tags&attributes.
Q: do we need to change the pattern to support attributes that starts with digit?
note: this tag "#affected+injured+dineo+y2017" is valid

@davidmegginson
Copy link
Member

We can talk about changing the syntax. HXL was originally designed to use the same identifier syntax as Twitter hashtags or programming-language variables, which (at least at the time, in Twitter's case) don't allow a digit in first position; I've always used "+y2017" in a case like that.

In the meantime, libhxl-python shouldn't be rejecting the whole thing as valid HXL because of that one error; instead, it should just leave that column untagged. I'll look into it.

Test data: https://proxy.hxlstandard.org/hxl-test.json?url=https://data.humdata.org/dataset/67d69410-1f2f-43eb-a522-1fe9633828ea/resource/b487b498-c23f-4fdc-b92a-83c0fd2da73b/download/cyclone-2016-2022_hxl.xlsx

@danmihaila
Copy link
Contributor Author

@davidmegginson the test data is not valid anymore as the data source was updated to use "+y2017"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants