Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you tap an equipped pet/mount, the action should say 'Unequip' rather than 'Equip' #1372

Closed
saraolson opened this issue Sep 30, 2020 · 8 comments

Comments

@saraolson
Copy link
Collaborator

Tapping an equipped pet/mount to bring up possible actions will still say 'Equip' even though it is already equipped. Tapping that action will unequip the pet/mount, but the language should match the action.

@SlothHut
Copy link
Contributor

SlothHut commented Nov 6, 2020

Could I work on this?

@saraolson
Copy link
Collaborator Author

@SlothHut sure thing, i'll mark it as in progress for you

@saraolson saraolson removed this from the 3.1 milestone Nov 10, 2020
@shanaqui
Copy link

@SlothHut Hi! Just checking in whether you're still working on this. If not, or if we don't hear back from you within a week, I'll mark it as help wanted again so others know it's available to work on.

@alejandro-rios
Copy link
Contributor

If it's possible I would like to work on this

@SlothHut
Copy link
Contributor

SlothHut commented Mar 8, 2021

Hi @shanaqui, im not working on this anymore

@saraolson
Copy link
Collaborator Author

@alejandro-rios if you're still interested, you're welcome to take this on now! i'll keep it it as in progress for you unless you say otherwise!

@alejandro-rios
Copy link
Contributor

Fixed in this PR 🎉 🎉 🎉

@saraolson
Copy link
Collaborator Author

@alejandro-rios thank you! we'll review it next time we're working on android :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants