Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout is causing either application crash or noop #277

Closed
emersonford opened this issue Jul 26, 2019 · 0 comments · Fixed by #276
Closed

Logout is causing either application crash or noop #277

emersonford opened this issue Jul 26, 2019 · 0 comments · Fixed by #276

Comments

@emersonford
Copy link
Contributor

Somewhere in the dependency tree, agent-base is imported and wraps around the request method of https. Due to TooTallNate/node-agent-base#29, the code path for logout is using a signature of request that is out of sync with the signature in agent-base. This inevitably lead to the dropping of host and defaulting to localhost... as we are using Nginx for proxying and Cloudflare for SSL, we didn't have anything listening on localhost:443 and the whole registration application to crashed on each logout as the request error went unhandled. Even with handling, the logout request would become a noop as the logout call was never made to ground-truth.

Pull request #276 fixes the use of request to match the signature found in agent-base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants