Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX transform incompatible with React 19 #5068

Open
pzaczkiewicz-athenahealth opened this issue Aug 31, 2024 · 2 comments
Open

JSX transform incompatible with React 19 #5068

pzaczkiewicz-athenahealth opened this issue Aug 31, 2024 · 2 comments

Comments

@pzaczkiewicz-athenahealth

Describe the bug

According to React 19 documentation, React.createElement is not going to be supported anymore. React-datepicker@7.3.0 is still transforming its jsx using React.createElement instead of import { jsx } from 'react/jsx-runtime';

To be fair, React 19 is not out of canary status yet, but libraries should adapt prior to React 19 coming out of beta.

To Reproduce

I have not run the React 19 canary with react-datepicker yet. Going off of documentation, and react-datepicker build artefacts.

@hamidrezahanafi
Copy link
Contributor

@pzaczkiewicz-athenahealth React-datepicker 7.3 is not React 19 compatible. My PR should fix this #4979
I don't also see anywhere athat createElement is going to be deprecated https://react.dev/reference/react/createElement

@pzaczkiewicz-athenahealth
Copy link
Author

Sorry, I meant to link the React documentation in my original post: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#installing.

What's confusing, is the React 19 canary doesn't appear to have the console.warn described in this documentation. Maybe React.createElement isn't going away with React 19, but the writing is on the wall that it will be deleted eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants