Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMOutputPreparer should be extended to write complete streams #61

Closed
cmnbroad opened this issue Feb 3, 2016 · 1 comment
Closed

SAMOutputPreparer should be extended to write complete streams #61

cmnbroad opened this issue Feb 3, 2016 · 1 comment

Comments

@cmnbroad
Copy link
Collaborator

cmnbroad commented Feb 3, 2016

SAMOutputPreparer knows how to prepare the beginning of an output stream, but not how to populate or terminate it (which for CRAM requires a special terminating EOF container). We should extend it do the whole roll-up correctly based on the SAMFormat being used.
@tomwhite tomwhite mentioned this issue Jul 6, 2016
Merged
@tomwhite
Copy link
Member

tomwhite commented Sep 9, 2016

Fixed in #111.

@tomwhite tomwhite closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomwhite @cmnbroad