Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Periodic packet loss #2041

Closed
gizahNL opened this issue Jun 17, 2021 · 3 comments · Fixed by #2043
Closed

[BUG] Periodic packet loss #2041

gizahNL opened this issue Jun 17, 2021 · 3 comments · Fixed by #2043
Assignees
Labels
[core] Area: Changes in SRT library core Priority: Critical Type: Bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@gizahNL
Copy link

gizahNL commented Jun 17, 2021

Describe the bug
Git commit 9848d68 has introduced stream breakage every 1hr and 11m where the stream breaks for exactly 3 seconds, and then seems to empty it's buffers on the output. Only the receiving side seems to be affected by this bug
Haivision/srtgo#19

To Reproduce
Compile from commit 9848d68 and upwards, setup a stream and receive it with the srt-live-transmit app build from commit 9848d68, the stream will break 1hr and 11m after start of the connection for 3 seconds.

image

@gizahNL gizahNL added the Type: Bug Indicates an unexpected problem or unintended behavior label Jun 17, 2021
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Priority: Critical labels Jun 17, 2021
@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Jun 17, 2021
@maxsharabayko maxsharabayko self-assigned this Jun 17, 2021
@oviano
Copy link
Contributor

oviano commented Jun 17, 2021

This is interesting, as since I grabbed updated srt code a month or so ago, I have become aware of something like this happening. The stream seems to freeze for a few seconds before recovering. I had put it down to just general network issues, but perhaps it relates to this.

It’s rare, and I am now going to keep an eye out and see if it happens every one hour 11 minutes!

@maxsharabayko
Copy link
Collaborator

Hi @gizahNL
Thanks for noticing and tracking down to the exact commit!
Indeed, this issue was introduced in PR #1968.
The fix is submitted in PR #2043.

@gizahNL
Copy link
Author

gizahNL commented Jun 18, 2021

Hi @gizahNL
Thanks for noticing and tracking down to the exact commit!
Indeed, this issue was introduced in PR #1968.
The fix is submitted in PR #2043.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Priority: Critical Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants