Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Caller should not connect to another Caller #2557

Closed
bpolic opened this issue Nov 28, 2022 · 2 comments · Fixed by #2562
Closed

[BUG] Caller should not connect to another Caller #2557

bpolic opened this issue Nov 28, 2022 · 2 comments · Fixed by #2562
Labels
[core] Area: Changes in SRT library core Priority: High Type: Bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@bpolic
Copy link
Collaborator

bpolic commented Nov 28, 2022

Describe the bug
Caller can be connected to another Caller!

Linux machine 1 IP: yy.yy.yy.yy
Linux machine 2 IP: xx.xx.xx.xx

To Reproduce
Steps to reproduce the behavior:

  1. Use 2 Linux machines
  2. Build a SRT Library
  3. Run caller on first machine: ./srt-xtransmit receive "srt://xx.xx.xx.xx:4200?latency=500&bind=:4200" -v
  4. Run caller on first machine: ./srt-xtransmit generate "srt://yy.yy.yy.yy:4200?latency=500&bind=:4200" -v --duration 20 --sendrate 5Mbps

Current behavior:
Caller can be connected to another Caller! Data transition will be interrupted before expected time in this case 20 sec. Connection will be closed before 20 sec

Expected behavior
Connection rejection

Desktop (please provide the following information):

  • OS: Linux
  • SRT Version 1.5.1
@bpolic bpolic added the Type: Bug Indicates an unexpected problem or unintended behavior label Nov 28, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 28, 2022
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Priority: High labels Nov 28, 2022
@bpolic
Copy link
Collaborator Author

bpolic commented Dec 6, 2022

Tested on latest master:
Inconsistent behavior, if we want to connect 2 caller, sometimes we have:

19:11:17.486855 [D] SOCKET::SRT 0x312615FF ASYNC Connecting to srt://10.129.10.81:4200
19:11:20.491838 [D] SOCKET::SRT 0x312615FF connect failed. ERROR: Connection timeout.
19:11:20.491980 [D] SOCKET::SRT 0x312615FF Releasing epolls before closing
19:11:20.492018 [D] SOCKET::SRT 0x312615FF Closing

sometimes:

[haivision@big-flop bin]$ ./srt-xtransmit generate "srt://10.129.10.81:4200?latency=500&bind=:4200" -v --duration 20 --sendrate 5Mbps
19:12:18.076715 [I] SOCKET::SRT srt://10.129.10.81:4200: bound to ':4200'.
19:12:18.076866 [D] SOCKET::SRT 0x3726BAFC ASYNC Connecting to srt://10.129.10.81:4200
19:12:18.078129 [D] SOCKET::SRT 0x3726BAFC ASYNC Connected to srt://10.129.10.81:4200
19:12:18.078177 [I] PACER sendrate 5000000 bps (inter send interval 2105 us)
19:12:19.078425 [I] GENERATE Sending at 4990 kbps
19:12:20.078550 [I] GENERATE Sending at 5000 kbps
19:12:21.078679 [I] GENERATE Sending at 5000 kbps
19:12:22.078789 [I] GENERATE Sending at 5000 kbps
19:12:23.078904 [I] GENERATE Sending at 5000 kbps
19:12:23.199022 [D] SOCKET::SRT 0x3726BAFC write::send. ERROR: Connection was broken.
19:12:23.199083 [W] GENERATE write::send: Connection was broken
19:12:23.199106 [D] SOCKET::SRT 0x3726BAFC Releasing epolls before closing
19:12:23.199132 [D] SOCKET::SRT 0x3726BAFC Closing

Maybe to reopen bug ticket?

@maxsharabayko maxsharabayko reopened this Dec 7, 2022
@bpolic bpolic closed this as completed Dec 13, 2022
@bpolic
Copy link
Collaborator Author

bpolic commented Dec 13, 2022

Retested after fix, working as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Priority: High Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants