Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statistics: Count Packets Dropped by a Group at the Start of Receiving #2936

Closed
maxsharabayko opened this issue Apr 22, 2024 · 0 comments · Fixed by #2945
Closed

Statistics: Count Packets Dropped by a Group at the Start of Receiving #2936

maxsharabayko opened this issue Apr 22, 2024 · 0 comments · Fixed by #2945
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Milestone
v1.5.4

Comments

@maxsharabayko
Copy link
Collaborator

PR #2934 fixes group statistics counting the number of packets dropped by a group. However, the counting starts only after the very first packet has been read from one of the members. This initializes the base sequence number m_RcvBaseSeqNo used to count the stats.
Therefore, if a drop happens in the beginning of the transmission, an SRT group would not count it.

SRT v1.5.4-dev.
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Apr 22, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 22, 2024
This was referenced Apr 22, 2024
Merged
Merged
@maxsharabayko maxsharabayko mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging a pull request may close this issue.

[core] Group set the RCV base seqno using peer ISN. maxsharabayko/srt
1 participant
@maxsharabayko